Add Azure SignalR to SignalR transport #2008
Merged
+65
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there's almost no difference between the two I just added the
Microsoft.Azure.SignalRnuget directly toWolverine.SignalR. If you'd rather have a separate package that extendsWolverine.SignalR, just say the word (and should it then be Wolverine.AzureSignalR, or Wolverine.SignalR.Azure?)I haven't added any automated tests, since I'm a bit unsure how to test SignalR properly. None of the existing SignalR-tests have broken. Some manual testing shows that messages gets sent correctly between clients.